Drop deprecated ExtLibeventLoop and ExtLibevLoop (PHP 5 only)#273
Merged
WyriHaximus merged 1 commit intoreactphp:3.xfrom Feb 5, 2024
Merged
Drop deprecated ExtLibeventLoop and ExtLibevLoop (PHP 5 only)#273WyriHaximus merged 1 commit intoreactphp:3.xfrom
ExtLibeventLoop and ExtLibevLoop (PHP 5 only)#273WyriHaximus merged 1 commit intoreactphp:3.xfrom
Conversation
clue
force-pushed
the
legacy-extensions
branch
from
f7f1955 to
8180e67
Compare
SimonFrings
approved these changes
Feb 5, 2024
WyriHaximus
approved these changes
Feb 5, 2024
Member
WyriHaximus
left a comment
WyriHaximus
left a comment
There was a problem hiding this comment.
Really happy to see all these old event loops be removed 
WilliamDEdwards
added a commit
to WilliamDEdwards/docs
that referenced
this pull request
Jun 6, 2024
taylorotwell
pushed a commit
to laravel/docs
that referenced
this pull request
Jun 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simple changeset drops the legacy and long deprecated
ExtLibeventLoop(ext-libevent) andExtLibevLoop(ext-libev) loop implementations. Both extensions will be used only on legacy PHP 5 and never received any updates for PHP 7+. TheExtLibeventLoophas been replaced byExtEventLoop, whileExtLibevLoophas been replaced byExtEvLoop, both of which continue to be fully supported. As a consequence, while technically a BC break, there is little chance this will affect any existing projects.Once merged, I will update the project to require PHP 7.1+ as discussed in #271 in a follow-up PR. I'm also going to clean up the test matrix now that most of the legacy cruft has been removed (see countless hours spent on #230, #264, #268, #270, and many others).
Builds on top of #234, #128, #127, #62, #55, #40, and others